[
https://issues.apache.org/jira/browse/HADOOP-18865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759068#comment-17759068
]
ASF GitHub Bot commented on HADOOP-18865:
-----------------------------------------
steveloughran commented on code in PR #5987:
URL: https://github.com/apache/hadoop/pull/5987#discussion_r1305728584
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -751,6 +752,15 @@ public AbfsRestOperation append(final String path, final
byte[] buffer,
}
}
+ // Check if the retry is with "Expect: 100-continue" header being present
in the previous request.
Review Comment:
not sure about this strategy of patching/replacing the ua header
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClient.java:
##########
@@ -86,6 +86,7 @@ public final class ITestAbfsClient extends
AbstractAbfsIntegrationTest {
private static final String ACCOUNT_NAME =
"bogusAccountName.dfs.core.windows.net";
private static final String FS_AZURE_USER_AGENT_PREFIX = "Partner Service";
+ private static final String HUNDRED_CONTINUE_USER_AGENT = SINGLE_WHITE_SPACE
+ HUNDRED_CONTINUE + SEMICOLON;
Review Comment:
normally i'd say "use the AbfsClient const", but here we have regression
testing that the client constant doesn't diverge from what the server expects,
so I`m happy
> ABFS: Adding 100 continue in userAgent String and dynamically removing it if
> retry is without the header enabled.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-18865
> URL: https://issues.apache.org/jira/browse/HADOOP-18865
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 3.3.6
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.3.6
>
>
> Adding 100 continue in userAgent String if enabled in AbfsConfiguration and
> dynamically removing it if retry is without the header enabled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
