[ 
https://issues.apache.org/jira/browse/HADOOP-18865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759645#comment-17759645
 ] 

ASF GitHub Bot commented on HADOOP-18865:
-----------------------------------------

steveloughran commented on code in PR #5987:
URL: https://github.com/apache/hadoop/pull/5987#discussion_r1307679757


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -751,6 +752,15 @@ public AbfsRestOperation append(final String path, final 
byte[] buffer,
       }
     }
 
+    // Check if the retry is with "Expect: 100-continue" header being present 
in the previous request.

Review Comment:
   > t would need the userAgent header to be updated for each append request 
making the operation costly.
   
   is it expensive? as I've been wondering what it would take the patch the 
referrer header on every request so we can attach the same audit information we 
do for s3a calls and which are wonderful for support requests...





> ABFS: Adding 100 continue in userAgent String and dynamically removing it if 
> retry is without the header enabled.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-18865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18865
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 3.3.6
>            Reporter: Anmol Asrani
>            Assignee: Anmol Asrani
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.3.6
>
>
> Adding 100 continue in userAgent String if enabled in AbfsConfiguration and 
> dynamically removing it if retry is without the header enabled.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to