mehakmeet commented on code in PR #5893:
URL: https://github.com/apache/hadoop/pull/5893#discussion_r1312968842
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingLruEviction.java:
##########
@@ -172,6 +174,8 @@ public void testSeeksWithLruEviction() throws Throwable {
LambdaTestUtils.eventually(TIMEOUT_MILLIS, INTERVAL_MILLIS, () -> {
LOG.info("IO stats: {}", ioStats);
verifyStatisticGaugeValue(ioStats, STREAM_READ_BLOCKS_IN_FILE_CACHE, 0);
+ assertThatStatisticCounter(ioStats,
+ STREAM_EVICT_BLOCKS_FROM_FILE_CACHE).isGreaterThanOrEqualTo(5);
Review Comment:
since this is `eventually()`, should we set the number of evictions that
would be happening eventually rather than a least number?
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java:
##########
@@ -444,6 +444,7 @@ private void deleteBlockFileAndEvictCache(Entry
elementToPurge) {
entryListSize--;
prefetchingStatistics.blockRemovedFromFileCache();
blocks.remove(elementToPurge.blockNumber);
+ prefetchingStatistics.blockEvictedFromFileCache();
Review Comment:
So, blocks removed from the cache would be equal to the blocks evicted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
