KeeProMise commented on code in PR #5990:
URL: https://github.com/apache/hadoop/pull/5990#discussion_r1313862686
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -599,6 +599,9 @@ public Object invokeMethod(
}
LOG.error("Cannot get available namenode for {} {} error: {}",
nsId, rpcAddress, ioe.getMessage());
+ if (this.namenodeResolver != null) {
+ this.namenodeResolver.rotateCache(nsId, namenode,
shouldUseObserver);
Review Comment:
added log, Since this is a bug, most users must fix the bug by default, so I
don’t think there is a need to add config here. I’m not sure there is a
situation where users don’t need to fix the bug.
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -599,6 +599,9 @@ public Object invokeMethod(
}
LOG.error("Cannot get available namenode for {} {} error: {}",
nsId, rpcAddress, ioe.getMessage());
+ if (this.namenodeResolver != null) {
+ this.namenodeResolver.rotateCache(nsId, namenode,
shouldUseObserver);
Review Comment:
added log, Since this is a bug, most users must fix the bug by default, so I
don’t think there is a need to add config here. I’m not sure there is a
situation where users don’t need to fix the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
