KeeProMise commented on code in PR #5990:
URL: https://github.com/apache/hadoop/pull/5990#discussion_r1314747600
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MembershipNamenodeResolver.java:
##########
@@ -488,7 +488,7 @@ public void setRouterId(String router) {
* @param listObserversFirst Observer read case, observer NN will be ranked
first
*/
@Override
- public synchronized void rotateCache(
+ public void rotateCache(
String nsId, FederationNamenodeContext namenode, boolean
listObserversFirst) {
Review Comment:
cacheNS instance of ConcurrentHashMap, so the compute method is atomic, we
can delete synchronized of the method rotateCache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
