GauthamBanasandra commented on code in PR #6032: URL: https://github.com/apache/hadoop/pull/6032#discussion_r1324423739
########## Blanks_eol.py: ########## @@ -0,0 +1,23 @@ +import os +import re + +def trim_right_spaces(text): + return text.rstrip() + +def main(): Review Comment: You need to add a docstring for every function that you create. You may follow [this](https://github.com/apache/hadoop/blob/9c8cdbe28e317e703560c3eefcde2f6eebcabb17/dev-support/docker/pkg-resolver/check_platform.py#L28-L30). ########## Blanks_eol.py: ########## @@ -0,0 +1,23 @@ +import os Review Comment: @Prajwal-Surendra could you please add the license header as done [here](https://github.com/apache/hadoop/blob/9c8cdbe28e317e703560c3eefcde2f6eebcabb17/dev-support/docker/pkg-resolver/check_platform.py#L1-L17)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
