saxenapranav commented on code in PR #6025:
URL: https://github.com/apache/hadoop/pull/6025#discussion_r1328582191
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/StorageInterfaceImpl.java:
##########
@@ -435,6 +456,24 @@ public void startCopyFromBlob(CloudBlobWrapper sourceBlob,
BlobRequestOptions op
null, dstAccessCondition, options, opContext);
}
+ @Override
+ public void startCopyFromBlob(CloudBlobWrapper sourceBlob,
BlobRequestOptions options,
+ OperationContext opContext, boolean
overwriteDestination, String eTag)
+ throws StorageException, URISyntaxException {
+ AccessCondition dstAccessCondition =
+ overwriteDestination
+ ? null
+ : AccessCondition.generateIfNotExistsCondition();
+ if (dstAccessCondition != null) {
+ dstAccessCondition.setIfMatch(eTag);
Review Comment:
You mean that overwrite will be false in copy flow, and overwrite be true in
putblocklist temp file flow?
This is a public method exposed and should be agnostic to what calls it.
Hence, better if we can prevent both conditions coming into accessCondition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
