anmolanmol1234 commented on PR #6025: URL: https://github.com/apache/hadoop/pull/6025#issuecomment-1723322521
> In the new overloaded methods in which etag is introduced as a parameter. Lets, specify if they are srcEtag or dstEtag. Reason being, from reading that particular method, it becomes confusing and would need reference check. > > Also, not all flows of rename flows in the etag. Copy / delete happens there as well. Is etag checks not required there? > > Also, as a prevention for bad-code add in future, can unit tests be added. > > Thanks. 1) Added that for clarification. 2) Not all rename flows need update, only updating the rename flow for creating a file. 3) Running the test suite was able to catch the eTag failures, but can be taken up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
