Hexiaoqiao commented on code in PR #6109:
URL: https://github.com/apache/hadoop/pull/6109#discussion_r1339444303
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -3822,5 +3822,10 @@ public long getLastDirScannerFinishTime() {
public void setLastDirScannerFinishTime(long time) {
this.lastDirScannerFinishTime = time;
}
+
+ @Override
+ public long getPendingAsyncDiskOperations() {
Review Comment:
I see, However we expose `PendingAsyncDiskOperations` to metric but invoke
`countPendingDeletions`, it could be confused to other devs. Suggest to unify
the define at both side if changes. Thanks.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -3822,5 +3822,10 @@ public long getLastDirScannerFinishTime() {
public void setLastDirScannerFinishTime(long time) {
this.lastDirScannerFinishTime = time;
}
+
+ @Override
+ public long getPendingAsyncDiskOperations() {
+ return this.asyncDiskService.countPendingDeletions();
Review Comment:
Here `this.asyncDiskService` should use `asyncDiskService` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
