haiyang1987 commented on code in PR #6109:
URL: https://github.com/apache/hadoop/pull/6109#discussion_r1339876416
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -3822,5 +3822,10 @@ public long getLastDirScannerFinishTime() {
public void setLastDirScannerFinishTime(long time) {
this.lastDirScannerFinishTime = time;
}
+
+ @Override
+ public long getPendingAsyncDiskOperations() {
Review Comment:
Thanks @Hexiaoqiao for your suggestions.
You are right, the method name definitions at both sides need to be
consistent.
From the current implementation, it might be better to changing
`countPendingDeletions` to `countPendingAsyncDiskOperations`, and add some
comments to this, indicating that the current method returns the pending number
include deletion of block files and requesting sync_file_range() operations,
what do you think about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
