[
https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774220#comment-17774220
]
ASF GitHub Bot commented on HADOOP-18930:
-----------------------------------------
xinglin commented on code in PR #6168:
URL: https://github.com/apache/hadoop/pull/6168#discussion_r1355506430
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java:
##########
@@ -1183,12 +1183,17 @@ private Constants() {
/**
* Flag for create performance.
- * This is *not* a configuration option; it is for use in the
- * {code createFile()} builder.
+ * This can be set in the {code createFile()} builder.
Review Comment:
can we add what "create performance" means or change it to a more meaningful
name, such as `fs.s3a.create.skip.file.existence.check `or
`fs.s3a.create.overwrite-if-exist`, or just as simple as
`fs.s3a.create.overwrite` and then add a comment about what it means?
> make fs.s3a.create.performance an option you can set for the entire bucket
> --------------------------------------------------------------------------
>
> Key: HADOOP-18930
> URL: https://issues.apache.org/jira/browse/HADOOP-18930
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 3.3.9
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> make the fs.s3a.create.performance option something you can set everywhere,
> rather than just in an openFile() option or under a magic path.
> this improves performance on apps like iceberg where filenames are generated
> with UUIDs in them, so we know there are no overwrites
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
