[ 
https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775122#comment-17775122
 ] 

ASF GitHub Bot commented on HADOOP-18930:
-----------------------------------------

xinglin commented on code in PR #6168:
URL: https://github.com/apache/hadoop/pull/6168#discussion_r1359140744


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -656,6 +657,11 @@ public void initialize(URI name, Configuration 
originalConf)
       // verify there's no S3Guard in the store config.
       checkNoS3Guard(this.getUri(), getConf());
 
+      // performance creation flag for code which wants performance

Review Comment:
   can we move comment here to where this property MACRO is defined? easy to 
find there.





> make fs.s3a.create.performance an option you can set for the entire bucket
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-18930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/s3
>    Affects Versions: 3.3.9
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> make the fs.s3a.create.performance option something you can set everywhere, 
> rather than just in an openFile() option or under a magic path.
> this improves performance on apps like iceberg where filenames are generated 
> with UUIDs in them, so we know there are no overwrites



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to