[
https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778020#comment-17778020
]
ASF GitHub Bot commented on HADOOP-18920:
-----------------------------------------
xinglin commented on code in PR #6146:
URL: https://github.com/apache/hadoop/pull/6146#discussion_r1367667472
##########
hadoop-common-project/hadoop-common/src/main/resources/core-default.xml:
##########
@@ -2520,6 +2520,16 @@ The switch to turn S3A auditing on or off.
</description>
</property>
+<property>
+ <name>ipc.server.log.slow.rpc-threshold-ms</name>
+ <value>0</value>
+ <description>The threshold in milliseconds for log slow rpc when
ipc.server.log.slow.rpc is enabled.
+ If a request took significant more time than other requests,
+ and its processing time is exceed `logSlowRPCThresholdMs` will consider
that as a slow RPC.
+ By default, this parameter is set 0.
+ </description>
Review Comment:
English changes: could we change to the following?
The threshold in milliseconds for **logging** slow rpc when
ipc.server.log.slow.rpc is enabled. Besides of being much slower than other RPC
requests, an RPC request has to take at least the threshold value defined by
this property before it can be considered as slow. By default, this threshold
is set to 0 (disabled).
> RPC Metrics : Optimize logic for log slow RPCs
> ----------------------------------------------
>
> Key: HADOOP-18920
> URL: https://issues.apache.org/jira/browse/HADOOP-18920
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> HADOOP-12325 implement a capability where "slow" RPCs are logged in NN log.
> Current processing logic is the "slow" RPCs are to be those whose processing
> time is outside 3 standard deviation.
> However, in practice it is found that many logs of slow rpc are currently
> output, and sometimes RPCs with a processing time of 1ms are also declared as
> slow, this is not in line with actual expectations.
> Therefore, consider optimize the logic conditions of slow RPC and add a
> `logSlowRPCThresholdMs` variable to judge whether the current RPCas slow so
> that the expected slow RPC log can be logger.
> for `logSlowRPCThresholdMs`, we can support dynamic refresh to facilitate
> adjustments based on the actual operating conditions of the hdfs cluster.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
