[
https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778236#comment-17778236
]
ASF GitHub Bot commented on HADOOP-18920:
-----------------------------------------
xinglin commented on PR #6146:
URL: https://github.com/apache/hadoop/pull/6146#issuecomment-1773934527
Ran these two unit tests for 20 times and none failed. change lgtm.
```
[xinglin@xinglin-ld1 hadoop-common]$ grep "Tests run" ZKCurator-fix.log
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.386
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.124 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.391
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.033 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.615
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.194 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.434
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.034 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.585
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.07
s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.485
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.027 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.441
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.289 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.516
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.03
s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.498
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.389 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.439
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.197 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.516
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
21.961 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.463
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.027 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.608
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.113 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.498
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.21
s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.449
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.149 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.483
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.121 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.508
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.099 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.466
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.209 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.494
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.025 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.515
s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
22.011 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[xinglin@xinglin-ld1 hadoop-common]$ git br
* HADOOP-18920
[xinglin@xinglin-ld1 hadoop-common]$ git log
commit ff8f32fff5f4f06853dedfb09978bb870e784131 (HEAD -> HADOOP-18920)
Author: Haiyang.Hu <[email protected]>
Date: Sat Oct 21 13:51:46 2023 +0800
HADOOP-18920. Modify patch based on comments
commit fd36114cce288d965f5501b4f1015a3c185ab908
Author: Haiyang.Hu <[email protected]>
Date: Thu Oct 19 13:12:27 2023 +0800
trigger ci
```
> RPC Metrics : Optimize logic for log slow RPCs
> ----------------------------------------------
>
> Key: HADOOP-18920
> URL: https://issues.apache.org/jira/browse/HADOOP-18920
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> HADOOP-12325 implement a capability where "slow" RPCs are logged in NN log.
> Current processing logic is the "slow" RPCs are to be those whose processing
> time is outside 3 standard deviation.
> However, in practice it is found that many logs of slow rpc are currently
> output, and sometimes RPCs with a processing time of 1ms are also declared as
> slow, this is not in line with actual expectations.
> Therefore, consider optimize the logic conditions of slow RPC and add a
> `logSlowRPCThresholdMs` variable to judge whether the current RPCas slow so
> that the expected slow RPC log can be logger.
> for `logSlowRPCThresholdMs`, we can support dynamic refresh to facilitate
> adjustments based on the actual operating conditions of the hdfs cluster.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
