xinglin commented on code in PR #6183:
URL: https://github.com/apache/hadoop/pull/6183#discussion_r1392934193
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java:
##########
@@ -144,7 +149,14 @@ public QuorumJournalManager(Configuration conf,
this.uri = uri;
this.nsInfo = nsInfo;
this.nameServiceId = nameServiceId;
- this.loggers = new AsyncLoggerSet(createLoggers(loggerFactory));
+ this.loggers = new AsyncLoggerSet(createLoggers(loggerFactory),
this.quorumJournalCount);
Review Comment:
this.quorumJournalCount is set inside createLoggers(). Can we separate them
as two separate steps, like the following?
```
// Keep this in comment:
// createLoggers() will set quorumJournalCount to total number of journal
nodes while return a list of healthy/good journal nodes.
List<AsyncLogger> loggers = createLoggers(loggerFactory);
this.loggers = new AsyncLoggerSet(loggers, this.quorumJournalCount);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
