xinglin commented on code in PR #6183:
URL: https://github.com/apache/hadoop/pull/6183#discussion_r1392943712
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java:
##########
@@ -250,6 +262,9 @@ Map<AsyncLogger, NewEpochResponseProto>
createNewUniqueEpoch()
@Override
public void format(NamespaceInfo nsInfo, boolean force) throws IOException {
+ if (isEnableJnMaintenance()) {
+ throw new IOException("format() does not support enabling jn maintenance
mode");
Review Comment:
nit:
`isEnableJnMaintenance(`) -> `isJNMainteanceEnabled()` or should it actually
be `IsJNInMaintenanceMode()` ?
"format() does not support enabling jn maintenance mode" -> "Formatting a
journal node is not supported while in JN maintenance mode"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
