ayushtkn commented on code in PR #6231: URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397266601
########## pom.xml: ########## @@ -225,6 +225,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <bannedImport>org.apache.hadoop.thirdparty.com.google.common.io.BaseEncoding.**</bannedImport> </bannedImports> </restrictImports> + <restrictImports> + <includeTestCode>true</includeTestCode> + <reason>Use java.nio.charset.StandardCharsets rather than Guava provided Charsets</reason> Review Comment: Are we ok having ``java.nio.charset.Charset`` ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/ServletUtils.java: ########## @@ -24,14 +24,15 @@ import javax.servlet.http.HttpServletRequest; import java.io.IOException; import java.nio.charset.Charset; +import java.nio.charset.StandardCharsets; import java.util.List; /** * Servlet utility methods. */ @InterfaceAudience.Private class ServletUtils { - private static final Charset UTF8_CHARSET = Charset.forName("UTF-8"); + private static final Charset UTF8_CHARSET = StandardCharsets.UTF_8; Review Comment: I don't think we need this constant we can directly use ``StandardCharsets.UTF_8;`` below & eliminate `` import java.nio.charset.Charset`` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
