pjfanning commented on code in PR #6231: URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397275697
########## pom.xml: ########## @@ -225,6 +225,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <bannedImport>org.apache.hadoop.thirdparty.com.google.common.io.BaseEncoding.**</bannedImport> </bannedImports> </restrictImports> + <restrictImports> + <includeTestCode>true</includeTestCode> + <reason>Use java.nio.charset.StandardCharsets rather than Guava provided Charsets</reason> Review Comment: Yes - we still need java.nio.charset.Charset. The StandardCharsets are implementations of the Charset interface and there are cases where we need to call Charset.forName when the charset is not hardcoded to UTF-8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
