hfutatzhanghb commented on code in PR #6348:
URL: https://github.com/apache/hadoop/pull/6348#discussion_r1424826707
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestDatanodeManager.java:
##########
@@ -1126,4 +1127,33 @@ public MockDfsNetworkTopology(){
super();
}
}
+
+ @Test
+ public void testComputeReconstructedTaskNum() {
+ int xmitsInProgress = 13000000;
Review Comment:
One minor suggestion. We should better add an UT that `totalReplicateBlocks
* maxTransfers` overflow been fixed here, because it is the reason causes
xmitsInProgress be very large. Others LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
