tasanuma commented on PR #6348: URL: https://github.com/apache/hadoop/pull/6348#issuecomment-1854136818
Thanks for reporting the issue and submitting the PR, @zhtttylz. The main fix looks good. But I have concerns about the unit test because they pass even without the main fix. Also, I don't think `...Fixed` or `...Origin` are good names for methods. Source code changes all the time, so method names should reflect what they do. I think you can create an overflow situation by passing large numbers as arguments into the `verifyPendingRecoveryTasks` method. `TestDatanodeManager#testPendingRecoveryTasks` might give you some ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
