ayushtkn commented on code in PR #6379:
URL: https://github.com/apache/hadoop/pull/6379#discussion_r1435864191
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/ECAdmin.java:
##########
@@ -642,6 +642,10 @@ public int run(Configuration conf, List<String> args)
throws IOException {
throw e;
}
} else {
+ if (args.size() > 0) {
+ System.err.println(getName() + ": Too many arguments");
Review Comment:
It works as designed, if you don't specify any policy the result is if all
the policies enabled can work or not & the minimum number of datanodes required
for each of them.
It is validating cluster setup for the enabled policies, not per policy
setup.
if you specify multiple policies, it provides the aggregate result, like if
all those policies can work on the cluster or not & if not a combined message
like how man DN are required.
like
```
9 DataNodes are required for the erasure coding policies: RS-6-3-1024k,
XOR-2-1-1024k. The number of DataNodes is only 3.
```
Like here, 9 is required number because of 6-3.
If we intend to improve the behaviour we can think if there is a need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
