ayushtkn commented on code in PR #6379:
URL: https://github.com/apache/hadoop/pull/6379#discussion_r1435934137
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/ECAdmin.java:
##########
@@ -642,6 +642,10 @@ public int run(Configuration conf, List<String> args)
throws IOException {
throw e;
}
} else {
+ if (args.size() > 0) {
+ System.err.println(getName() + ": Too many arguments");
Review Comment:
If you pass multiple policies, that means you want a combined result, like
if all these are supported or not in the "cluster", if you want one policy,
pass one policy only.
The whole design is to verify things at cluster level, not at policy level.
To highlight cluster level setup issues, like all the enabled policies aren't
supported & things like that, it was created for cluster admin level usage.
you can add an additional option which tells the result per policy if the
additional option is provided, in that case post getting the result, it can
loop over the policies and get individual result, changing proto & all is like
last things to do, but I don't think it is required as of now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
