GauthamBanasandra commented on PR #5820: URL: https://github.com/apache/hadoop/pull/5820#issuecomment-1871110495
Hi @ayushtkn, 1. Regarding the HDFS Native Client test failures - there are a lot of test failures on Windows. [Here's a run](https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/357/artifact/out/report.html) from our Nightly pipeline on Windows. We will eventually fix these tests to run on Windows. With the pre-commit CI that this PR proposes, I'm hoping that we catch any regression with the things that are currently passing -  2. Regarding the ASF license failure - this file isn't introduced by this PR. Upon checking further, [it turns out to be a binary file](https://github.com/apache/hadoop/blob/fc71dc3e94c8c89bdbecd24a77ab822b183b78b7/hadoop-common-project/hadoop-common/src/test/resources/lz4/sequencefile), to which we can't add a license header. I think we should just ignore this file from the license check. Pinging the author of this file, @viirya for further thoughts on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
