ayushtkn commented on PR #5820: URL: https://github.com/apache/hadoop/pull/5820#issuecomment-1871233821
Strange the linux build doesn't report any errors for license https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1453/console <img width="1311" alt="image" src="https://github.com/apache/hadoop/assets/25608848/8e4c7919-e323-4670-aef8-2dca80b4ed5b";> > I'm hoping that we catch any regression with the things that are currently passing With these many failing tests, how will other developers figure out which one is a regression & which was already broken? You should put the proposal of enabling the Pre-Commit for Windows for each PR on the dev list, I believe & let folks know the current state of the build before enabling it For the code changes, it LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
