KeeProMise commented on code in PR #6403:
URL: https://github.com/apache/hadoop/pull/6403#discussion_r1441243319
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -1647,16 +1661,8 @@ public synchronized boolean seekToNewSource(long
targetPos)
if (currentNode == null) {
return seekToBlockSource(targetPos);
}
- boolean markedDead = dfsClient.isDeadNode(this, currentNode);
- addToLocalDeadNodes(currentNode);
Review Comment:
Thanks for your review, seekToNewSource is a synchronous method, so the
method is atomic; and the method turns out to just add the current node to the
local deadnodes; so I think it will not affect the dead node detector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
