hfutatzhanghb commented on code in PR #6403:
URL: https://github.com/apache/hadoop/pull/6403#discussion_r1441251384
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -1647,16 +1661,8 @@ public synchronized boolean seekToNewSource(long
targetPos)
if (currentNode == null) {
return seekToBlockSource(targetPos);
}
- boolean markedDead = dfsClient.isDeadNode(this, currentNode);
- addToLocalDeadNodes(currentNode);
Review Comment:
Hi @KeeProMise , Let's think about below situation in original code:
we add currentNode to DFSInputStream#deadNodes, this field has a getter
method getLocalDeadNodes() which may be called by DFSClient and
DFSInputStream's non-synchronized method.
But, your modification remove the logic of adding currentNode to
DFSInputStream#deadNodes. The caller of getLocalDeadNodes() will be no aware of
changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
