tasanuma commented on PR #6510: URL: https://github.com/apache/hadoop/pull/6510#issuecomment-1918665891
@ayushtkn Thanks for the review. I've updated the PR to use `RouterObserverReadProxyProvider.class` in the logger. It seems that `RouterObserverReadProxyProvider` is simpler than `ObserverReadProxyProvider` as Router is handling some tasks for it. So, extending `ObserverReadProxyProvider` might not be the best approach. Indeed, there are some common fields and methods such as `autoMsyncIfNecessary()`, so creating an abstract class or an interface could be a good idea. I would like to hear @simbadzina 's opinion on this. By the way, @chunyiyang is actually a woman. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
