tasanuma commented on code in PR #6510:
URL: https://github.com/apache/hadoop/pull/6510#discussion_r1476059897
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/RouterObserverReadProxyProvider.java:
##########
@@ -84,7 +84,8 @@ public class RouterObserverReadProxyProvider<T> extends
AbstractNNFailoverProxyP
public RouterObserverReadProxyProvider(Configuration conf, URI uri, Class<T>
xface,
HAProxyFactory<T> factory) {
- this(conf, uri, xface, factory, new IPFailoverProxyProvider<>(conf, uri,
xface, factory));
+ this(conf, uri, xface, factory,
+ new ConfiguredFailoverProxyProvider<>(conf, uri, xface, factory));
Review Comment:
@simbadzina Thanks for your review and sharing your thoughts. I understand
that you intentionally chose `IPFailoverProxyProvider`.
> Can we make the proxy provider configurable? To support both usecases.
Are you suggesting that we create another configuration like
`dfs.client.failover.router.internal.proxy.provider`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
