tasanuma commented on code in PR #6510:
URL: https://github.com/apache/hadoop/pull/6510#discussion_r1476061151
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/RouterObserverReadProxyProvider.java:
##########
@@ -84,7 +84,8 @@ public class RouterObserverReadProxyProvider<T> extends
AbstractNNFailoverProxyP
public RouterObserverReadProxyProvider(Configuration conf, URI uri, Class<T>
xface,
HAProxyFactory<T> factory) {
- this(conf, uri, xface, factory, new IPFailoverProxyProvider<>(conf, uri,
xface, factory));
+ this(conf, uri, xface, factory,
+ new ConfiguredFailoverProxyProvider<>(conf, uri, xface, factory));
Review Comment:
As an alternative approach, what if we created a
`RouterObserverReadProxyProviderWithIPFailover` using `IPFailoverProxyProvider`
to align it with `ObserverReadProxyProviderWithIPFailover`?
```java
public class RouterObserverReadProxyProviderWithIPFailover<T>
extends RouterObserverReadProxyProvider<T> {
@VisibleForTesting
static final Logger LOG =
LoggerFactory.getLogger(RouterObserverReadProxyProviderWithIPFailover.class);
public RouterObserverReadProxyProviderWithIPFailover(Configuration conf,
URI uri, Class<T> xface,
HAProxyFactory<T> factory) {
super(conf, uri, xface, factory, new IPFailoverProxyProvider<>(conf,
uri, xface, factory));
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
