[
https://issues.apache.org/jira/browse/HADOOP-19071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831177#comment-17831177
]
ASF GitHub Bot commented on HADOOP-19071:
-----------------------------------------
slfan1989 commented on code in PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#discussion_r1540513670
##########
dev-support/bin/hadoop.sh:
##########
@@ -614,7 +615,7 @@ function shadedclient_rebuild
echo_and_redirect "${logfile}" \
"${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \
"${modules[@]}" \
- -DskipShade -Dtest=NoUnitTests -Dmaven.javadoc.skip=true
-Dcheckstyle.skip=true \
+ -DskipShade -Dsurefire.failIfNoSpecifiedTests=false -Dtest=NoUnitTests
-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \
Review Comment:
I carefully reviewed the build report, and
`-Dsurefire.failIfNoSpecifiedTests=false` is necessary because we have some
modules without JUnit tests. We use `-Dtest=NoUnitTests` to handle this, which
can cause an error.
> Update maven-surefire-plugin from 3.0.0 to 3.2.5
> -------------------------------------------------
>
> Key: HADOOP-19071
> URL: https://issues.apache.org/jira/browse/HADOOP-19071
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, common
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
