[ https://issues.apache.org/jira/browse/HADOOP-19071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833933#comment-17833933 ]
ASF GitHub Bot commented on HADOOP-19071: ----------------------------------------- steveloughran commented on code in PR #6664: URL: https://github.com/apache/hadoop/pull/6664#discussion_r1551706643 ########## hadoop-project/pom.xml: ########## @@ -221,6 +221,7 @@ <yarnpkg.version>v1.22.5</yarnpkg.version> <apache-ant.version>1.10.13</apache-ant.version> <jmh.version>1.20</jmh.version> + <surefire.module.config>-Dsurefire.failIfNoSpecifiedTests=false</surefire.module.config> Review Comment: not needed; will explain ########## hadoop-project/pom.xml: ########## @@ -2414,6 +2415,7 @@ <configuration> <reuseForks>false</reuseForks> <forkedProcessTimeoutInSeconds>${surefire.fork.timeout}</forkedProcessTimeoutInSeconds> + <surefire.module.config>${surefire.module.config}</surefire.module.config> Review Comment: add the options directly: ```xml <failIfNoSpecifiedTests>false</failIfNoSpecifiedTests> <trimStackTrace>false</trimStackTrace> ``` see [<failIfNoSpecifiedTests>](https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#failIfNoSpecifiedTests) > Update maven-surefire-plugin from 3.0.0 to 3.2.5 > ------------------------------------------------- > > Key: HADOOP-19071 > URL: https://issues.apache.org/jira/browse/HADOOP-19071 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, common > Affects Versions: 3.4.0, 3.5.0 > Reporter: Shilun Fan > Assignee: Shilun Fan > Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org