vinayakumarb commented on code in PR #6809:
URL: https://github.com/apache/hadoop/pull/6809#discussion_r1599005240
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java:
##########
@@ -626,7 +626,8 @@ private synchronized boolean checkLeases(Collection<Lease>
leasesToCheck) {
}
}
// If a lease recovery happened, we need to sync later.
Review Comment:
On the other hand, if we see the complete logic of `internalReleaseLease()`
we need to call logSync() always.
There are two possibilities overall.
1. File gets closed.
2. lease recovery gets initiated with reassign of lease.
In both of above cases, there will be edit txn logged. So need to call
logSync().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
