Hexiaoqiao commented on code in PR #6809:
URL: https://github.com/apache/hadoop/pull/6809#discussion_r1599314271
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java:
##########
@@ -626,7 +626,8 @@ private synchronized boolean checkLeases(Collection<Lease>
leasesToCheck) {
}
}
// If a lease recovery happened, we need to sync later.
Review Comment:
Thanks, I totally agree to write and sync edit log here where 'write'
already do that for both `close` and `reassign lease` but miss `sync` for some
corner case. My point is do we need to sync them invoke `logSync()` in time?
And what will it happen if sync by other write operation at following because
edit from LeaseManager.Monitor is one asynchronous logic which is not have to
in order IMO. Maybe it could be going to be missed if there are no other write
operation later then NameNode shutdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
