steveloughran commented on code in PR #6884:
URL: https://github.com/apache/hadoop/pull/6884#discussion_r1639812489
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -536,11 +542,15 @@ public static S3AFileStatus createFileStatus(Path keyPath,
String owner,
String eTag,
String versionId,
- boolean isCSEEnabled) {
+ S3Client s3Client,
Review Comment:
this isn't really going to trigger an http request is it?
look how we did it in the old code: we just lied about file length in
listings
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -18,6 +18,8 @@
package org.apache.hadoop.fs.s3a;
+import io.netty.util.internal.StringUtil;
Review Comment:
-1 to any dependency on netty in existing classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
