shameersss1 commented on code in PR #6884:
URL: https://github.com/apache/hadoop/pull/6884#discussion_r1639886722


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -536,11 +542,15 @@ public static S3AFileStatus createFileStatus(Path keyPath,
       String owner,
       String eTag,
       String versionId,
-      boolean isCSEEnabled) {
+      S3Client s3Client,

Review Comment:
   The s3 client is added to provide backward compatiblity with v1 client. It 
is turned off by default and hence no extra http call will be made



##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -18,6 +18,8 @@
 
 package org.apache.hadoop.fs.s3a;
 
+import io.netty.util.internal.StringUtil;

Review Comment:
   ack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to