[
https://issues.apache.org/jira/browse/HADOOP-18562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862564#comment-17862564
]
ASF GitHub Bot commented on HADOOP-18562:
-----------------------------------------
PradhanPrerak commented on code in PR #6550:
URL: https://github.com/apache/hadoop/pull/6550#discussion_r1663039637
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java:
##########
@@ -778,18 +778,18 @@ private Constants() {
/**
* List of custom headers to be set on the service client.
* Multiple parameters can be used to specify custom headers.
- * fs.s3a.s3.custom.headers - headers to add on all the s3 requests.
- * fs.s3a.sts.custom.headers - headers to add on all the sts requests.
+ * fs.s3a.client.s3.custom.headers - headers to add on all the s3 requests.
+ * fs.s3a.client.sts.custom.headers - headers to add on all the sts requests.
* Examples
* CustomHeader {@literal ->} 'Header1:Value1'
* CustomHeaders {@literal ->} 'Header1=Value1:Value2,Header2=Value1'
*/
public static final String CUSTOM_HEADERS_STS =
- "fs.s3a." + Constants.AWS_SERVICE_IDENTIFIER_STS.toLowerCase()
+ "fs.s3a.client." + Constants.AWS_SERVICE_IDENTIFIER_STS.toLowerCase()
Review Comment:
That would not right? `Constants.AWS_SERVICE_IDENTIFIER_STS.toLowerCase()`
is just STS.
> New configuration for static headers to be added to all S3 requests
> -------------------------------------------------------------------
>
> Key: HADOOP-18562
> URL: https://issues.apache.org/jira/browse/HADOOP-18562
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Daniel Carl Jones
> Priority: Minor
> Labels: pull-request-available
>
> Some users have the use case where for a particular S3A filesystem, they
> would like to set one or more headers to a static value.
> We might imagine a set of configurations properties with a common prefix,
> where the suffix determines the header name and the value of the property
> determines the value of the header.
> Per-filesystem headers can be set using the per-bucket configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
