muskan1012 commented on code in PR #6939:
URL: https://github.com/apache/hadoop/pull/6939#discussion_r1680458092
##########
hadoop-common-project/hadoop-auth/pom.xml:
##########
@@ -272,5 +272,68 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>java-8</id>
+ <activation>
+ <jdk>1.8</jdk>
+ </activation>
Review Comment:
> Why are these profiles being added in
`hadoop-common-project/hadoop-auth/pom.xml` instead of the root POM?
>
> 1. We may need the `--add-opens` args for other tests.
> 2. More importantly, the compiler settings should be global.
@adoroszlai Sure I will move it to hadoop-main pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
