pan3793 commented on code in PR #6939:
URL: https://github.com/apache/hadoop/pull/6939#discussion_r1692450733
##########
hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh:
##########
@@ -618,8 +618,7 @@ function hadoop_bootstrap
export HADOOP_OS_TYPE=${HADOOP_OS_TYPE:-$(uname -s)}
- # defaults
- export HADOOP_OPTS=${HADOOP_OPTS:-"-Djava.net.preferIPv4Stack=true"}
+ export HADOOP_OPTS="${HADOOP_OPTS:-"-Djava.net.preferIPv4Stack=true"}
-XX:+IgnoreUnrecognizedVMOptions
--add-exports=java.base/sun.security.x509=ALL-UNNAMED
--add-exports=java.base/sun.security.util=ALL-UNNAMED"
Review Comment:
I would suggest adding the JPMS opts in `function
hadoop_finalize_hadoop_opts` or add a dedicated function
`hadoop_finalize_jpms_opts`
also, we should add comments on both sides(here and pom.xml), to mention the
future contributors sync the jpms opts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
