[ 
https://issues.apache.org/jira/browse/HADOOP-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261050#comment-13261050
 ] 

Aaron T. Myers commented on HADOOP-8310:
----------------------------------------

bq. @Daryn - do you think that should be handled as part of another JIRA since 
this specifically addresses a different issue?

That would be my preference as well. Making FC use FS's checkPath 
implementation is a bigger, potentially more destabilizing change. It's also 
not obvious to me that such a change would be entirely compatible, consdering 
FS#checkPath currently throws IllegalArgEx, whereas FC throws InvalidPathEx.

Perhaps we can commit this patch as-is, and open another JIRA to make the two 
methods share code.

Is that OK by you, Daryn?
                
> FileContext#checkPath should handle URIs with no port
> -----------------------------------------------------
>
>                 Key: HADOOP-8310
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8310
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.0.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HADOOP-8310.patch
>
>
> AbstractFileSystem#checkPath is used to verify that a given path is for the 
> same file system as represented by the AbstractFileSystem instance.
> The original intent of the code was to allow for no port to be provided in 
> the checked path, if the default port was being used by the 
> AbstractFileSystem instance. However, before performing port handling, 
> AFS#checkPath compares the full URI authorities for equality. Since the URI 
> authority includes the port, the port handling code is never reached, and 
> thus valid paths may be erroneously considered invalid.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to