[
https://issues.apache.org/jira/browse/HADOOP-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261644#comment-13261644
]
Daryn Sharp commented on HADOOP-8310:
-------------------------------------
They actually are related. When I changed the {{FileSystem#checkPath}}
handling, I also removed {{DistributedFileSystem#checkPath}} due to redundancy
with the improved {{FileSystem#checkPath}}. Part of the change specifically
involved having {{FileSystem#checkPath}} handle default ports. That change is
probably what broke {{FileContext}}.
{{FileContext}} really should have identical URI handling to {{FileSystem}},
sans the exception types. {{InvalidPathException}} derives from
{{IllegalArgumentException}} so the difference won't matter esp. since
{{FileContext}} can continue to throw the path exception.
+0 All that said, I'm very reluctantly willing to let this patch go as-is if
there is a followup jira.
> FileContext#checkPath should handle URIs with no port
> -----------------------------------------------------
>
> Key: HADOOP-8310
> URL: https://issues.apache.org/jira/browse/HADOOP-8310
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Attachments: HADOOP-8310.patch
>
>
> AbstractFileSystem#checkPath is used to verify that a given path is for the
> same file system as represented by the AbstractFileSystem instance.
> The original intent of the code was to allow for no port to be provided in
> the checked path, if the default port was being used by the
> AbstractFileSystem instance. However, before performing port handling,
> AFS#checkPath compares the full URI authorities for equality. Since the URI
> authority includes the port, the port handling code is never reached, and
> thus valid paths may be erroneously considered invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
