[
https://issues.apache.org/jira/browse/HADOOP-19231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873294#comment-17873294
]
ASF GitHub Bot commented on HADOOP-19231:
-----------------------------------------
pjfanning commented on code in PR #6953:
URL: https://github.com/apache/hadoop/pull/6953#discussion_r1715907737
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/main/java/org/apache/hadoop/yarn/appcatalog/application/YarnServiceClient.java:
##########
@@ -46,6 +47,19 @@
public class YarnServiceClient {
private static final Logger LOG =
LoggerFactory.getLogger(YarnServiceClient.class);
+
+ /**
+ * It is more performant to reuse ObjectMapper instances but keeping the
instance
Review Comment:
I am a committer on the Jackson project. There is minimal synchronisation
and I am actively removing many of the remaining cases. Even today, it is more
performant to reuse ObjectMapper instead of creating multiple instances.
> add JacksonUtil to centralise some code
> ---------------------------------------
>
> Key: HADOOP-19231
> URL: https://issues.apache.org/jira/browse/HADOOP-19231
> Project: Hadoop Common
> Issue Type: Task
> Reporter: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> To future proof Hadoop against Jackson changes, it makes sense to not just
> create ObjectMappers and JsonFactories in many different places in the Hadoop
> code.
> One of the main drivers of this is
> https://www.javadoc.io/doc/com.fasterxml.jackson.core/jackson-core/latest/com/fasterxml/jackson/core/StreamReadConstraints.html
>
> Jackson 3 (not yet scheduled for release) has some fairly big API and
> behaviour changes too.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
