[
https://issues.apache.org/jira/browse/HADOOP-19231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873644#comment-17873644
]
ASF GitHub Bot commented on HADOOP-19231:
-----------------------------------------
pjfanning commented on code in PR #6953:
URL: https://github.com/apache/hadoop/pull/6953#discussion_r1717294227
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/RemoteSASKeyGeneratorImpl.java:
##########
@@ -29,6 +29,7 @@
import org.apache.hadoop.fs.azure.security.Constants;
import org.apache.hadoop.io.retry.RetryPolicy;
import org.apache.hadoop.io.retry.RetryUtils;
+import org.apache.hadoop.util.JacksonUtil;
Review Comment:
this line looks like it's in the right place but I did move a
com.fasterxml.jackson import that was separated from the others.
> add JacksonUtil to centralise some code
> ---------------------------------------
>
> Key: HADOOP-19231
> URL: https://issues.apache.org/jira/browse/HADOOP-19231
> Project: Hadoop Common
> Issue Type: Task
> Reporter: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> To future proof Hadoop against Jackson changes, it makes sense to not just
> create ObjectMappers and JsonFactories in many different places in the Hadoop
> code.
> One of the main drivers of this is
> https://www.javadoc.io/doc/com.fasterxml.jackson.core/jackson-core/latest/com/fasterxml/jackson/core/StreamReadConstraints.html
>
> Jackson 3 (not yet scheduled for release) has some fairly big API and
> behaviour changes too.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
