sadanand48 commented on code in PR #6968:
URL: https://github.com/apache/hadoop/pull/6968#discussion_r1773635798
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java:
##########
@@ -253,9 +253,8 @@ static long toLong(long preferredBlockSize, long
layoutRedundancy,
private BlockInfo[] blocks;
- INodeFile(long id, byte[] name, PermissionStatus permissions, long mtime,
- long atime, BlockInfo[] blklist, short replication,
- long preferredBlockSize) {
+ public INodeFile(long id, byte[] name, PermissionStatus permissions, long
mtime, long atime,
Review Comment:
This was done to fix the failing test at
[TestFileWithSnapshotFeature.java](https://github.com/apache/hadoop/pull/6968/files#diff-1dc61f49252bdd57529e44092586fe9adaba7b1f3f9b8c55e88b21b3ff2aa63d)
. The test was failing with the mockito-upgrade and in order to fix this, we
made the change.
There are a lot of differences b/w older mockito and newer and also b/w
mockito-core and inline which we have used in multiple places. So far we have
iteratively worked on this PR to check what works and almost reached a single
digit in terms of the failing unit tests for the mockito upgrade required to
support JDK 17 runtime.
Some differences I remember b/w mockito versions are : in older mockito
versions/mockito-core , it is allowed to call a real method although in
mockito-inline and later versions, every method call must be strictly stubbed
and define doReturn/doAnswer etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
