steveloughran commented on code in PR #6968: URL: https://github.com/apache/hadoop/pull/6968#discussion_r1795397931
########## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestServer.java: ########## @@ -18,6 +18,7 @@ package org.apache.hadoop.ipc; +import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions; Review Comment: import is in the wrong place ########## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestRestCsrfPreventionFilter.java: ########## @@ -18,6 +18,7 @@ package org.apache.hadoop.security.http; +import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions; Review Comment: import ordering ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSnapshotPathINodes.java: ########## @@ -17,6 +17,7 @@ */ package org.apache.hadoop.hdfs.server.namenode; +import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions; Review Comment: import ordering ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigArgumentHandler.java: ########## @@ -23,7 +23,7 @@ import static org.mockito.ArgumentMatchers.anyString; import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.verifyNoInteractions; +import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions; Review Comment: move to L19 ########## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java: ########## @@ -35,6 +35,7 @@ import org.junit.Assert; import org.junit.Test; import org.mockito.Mockito; +import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions; Review Comment: stick a blank between the static block and the others ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java: ########## @@ -36,7 +36,7 @@ import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.anyBoolean; import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.verifyNoInteractions; +import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions; Review Comment: L19 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/com/nec/TestNECVEPlugin.java: ########## @@ -25,7 +25,7 @@ import static org.mockito.Mockito.when; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.verifyNoInteractions; +import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions; Review Comment: move to L21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
