[
https://issues.apache.org/jira/browse/HADOOP-19284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884898#comment-17884898
]
ASF GitHub Bot commented on HADOOP-19284:
-----------------------------------------
anujmodi2021 commented on code in PR #7062:
URL: https://github.com/apache/hadoop/pull/7062#discussion_r1776526750
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java:
##########
@@ -451,7 +451,9 @@ public AbfsConfiguration(final Configuration rawConfig,
String accountName)
}
public Trilean getIsNamespaceEnabledAccount() {
- return Trilean.getTrilean(isNamespaceEnabledAccount);
+ String isNamespaceEnabledAccountString
Review Comment:
Hi, it seems fine to keep this name as well as it clarifies that it is the
Account's property that we are talking about not a Filesystem's property.
Besides, this has been the day 0 code and changing it would lead to a lot of
code changes everywhere where getter and setters are used. We have followed
same naming structure for this throughout driver code.
Would love to know your thoughts here.
> ABFS: Allow "fs.azure.account.hns.enabled" to be set as Account Specific
> Config
> -------------------------------------------------------------------------------
>
> Key: HADOOP-19284
> URL: https://issues.apache.org/jira/browse/HADOOP-19284
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> There are a few reported requirements where users working with multiple file
> systems need to specify this config either only for some accounts or set it
> differently for different account.
> ABFS driver today does not allow this to be set as account specific config.
> This Jira is to allow that as a new support.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]