[
https://issues.apache.org/jira/browse/HADOOP-19284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884934#comment-17884934
]
ASF GitHub Bot commented on HADOOP-19284:
-----------------------------------------
bhattmanish98 commented on code in PR #7062:
URL: https://github.com/apache/hadoop/pull/7062#discussion_r1776701095
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java:
##########
@@ -450,8 +450,17 @@ public AbfsConfiguration(final Configuration rawConfig,
String accountName)
this(rawConfig, accountName, AbfsServiceType.DFS);
}
+ /**
+ * Returns the account type as per the user configuration. Gets the account
+ * specific value if it exists, then looks for an account agnostic value.
+ * If not configured driver makes additional getAcl call to determine
+ * the account type during file system initialization.
+ * @return TRUE/FALSE value if configured, UNKNOWN if not configured.
+ */
public Trilean getIsNamespaceEnabledAccount() {
- return Trilean.getTrilean(isNamespaceEnabledAccount);
+ String isNamespaceEnabledAccountString
+ = getString(FS_AZURE_ACCOUNT_IS_HNS_ENABLED,
isNamespaceEnabledAccount);
+ return Trilean.getTrilean(isNamespaceEnabledAccountString);
Review Comment:
Since the variable isNamespaceEnabledAccountString is used at one place
only, shouldn't it be better to make it inplace call instead of creating new
variable?
> ABFS: Allow "fs.azure.account.hns.enabled" to be set as Account Specific
> Config
> -------------------------------------------------------------------------------
>
> Key: HADOOP-19284
> URL: https://issues.apache.org/jira/browse/HADOOP-19284
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> There are a few reported requirements where users working with multiple file
> systems need to specify this config either only for some accounts or set it
> differently for different account.
> ABFS driver today does not allow this to be set as account specific config.
> This Jira is to allow that as a new support.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
