zeekling commented on code in PR #7138:
URL: https://github.com/apache/hadoop/pull/7138#discussion_r1846910583
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerAsyncScheduling.java:
##########
@@ -927,7 +927,11 @@ public void testReleaseOutdatedReservedContainer() throws
Exception {
* First proposal should be accepted, second proposal should be rejected
* because it try to release an outdated reserved container
*/
- MockRM rm1 = new MockRM();
+ // disable async-scheduling for simulating complex scene
+ Configuration disableAsyncConf = new Configuration(conf);
+ disableAsyncConf.setBoolean(
+ CapacitySchedulerConfiguration.SCHEDULE_ASYNCHRONOUSLY_ENABLE, false);
Review Comment:
Why disable async scheduler in UT? And enable by default? I think we'd
better enable async schedule by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
