shameersss1 commented on code in PR #7138:
URL: https://github.com/apache/hadoop/pull/7138#discussion_r1848586005
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerAsyncScheduling.java:
##########
@@ -927,7 +927,11 @@ public void testReleaseOutdatedReservedContainer() throws
Exception {
* First proposal should be accepted, second proposal should be rejected
* because it try to release an outdated reserved container
*/
- MockRM rm1 = new MockRM();
+ // disable async-scheduling for simulating complex scene
+ Configuration disableAsyncConf = new Configuration(conf);
+ disableAsyncConf.setBoolean(
+ CapacitySchedulerConfiguration.SCHEDULE_ASYNCHRONOUSLY_ENABLE, false);
Review Comment:
The following are the reasons why async scheduling is disabled in UT :
1. unlike async scheduling, sync scheduling gives more flexibility while
writing UTs to mimic complex scenarios since the UT writer will have full
control over when to schedule, where as with async scheduling this cannot be
done.
2. There were 200+ failing when async scheduling was enabled (due to
scheduling assertion)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
