anmolanmol1234 commented on code in PR #7122:
URL: https://github.com/apache/hadoop/pull/7122#discussion_r1850213064
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBackoffMetrics.java:
##########
@@ -202,51 +204,68 @@ public void setMetricValue(AbfsBackoffMetricsEnum metric,
long value) {
1.RCTSI :- Request count that succeeded in x retries
2.MMA :- Min Max Average (This refers to the backoff or sleep time between 2
requests)
3.s :- seconds
- 4.BWT :- Number of Bandwidth throttled requests
- 5.IT :- Number of IOPS throttled requests
- 6.OT :- Number of Other throttled requests
- 7.NFR :- Number of requests which failed due to network errors
- 8.%RT :- Percentage of requests that are throttled
- 9.TRNR :- Total number of requests which succeeded without retrying
- 10.TRF :- Total number of requests which failed
- 11.TR :- Total number of requests which were made
- 12.MRC :- Max retry count across all requests
*/
- @Override
- public String toString() {
- if (getMetricValue(TOTAL_NUMBER_OF_REQUESTS) == 0) {
- return "";
+ private void getRetryMetrics(StringBuilder metricBuilder) {
Review Comment:
javadocs
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBackoffMetrics.java:
##########
@@ -202,51 +204,68 @@ public void setMetricValue(AbfsBackoffMetricsEnum metric,
long value) {
1.RCTSI :- Request count that succeeded in x retries
2.MMA :- Min Max Average (This refers to the backoff or sleep time between 2
requests)
3.s :- seconds
- 4.BWT :- Number of Bandwidth throttled requests
- 5.IT :- Number of IOPS throttled requests
- 6.OT :- Number of Other throttled requests
- 7.NFR :- Number of requests which failed due to network errors
- 8.%RT :- Percentage of requests that are throttled
- 9.TRNR :- Total number of requests which succeeded without retrying
- 10.TRF :- Total number of requests which failed
- 11.TR :- Total number of requests which were made
- 12.MRC :- Max retry count across all requests
*/
- @Override
- public String toString() {
- if (getMetricValue(TOTAL_NUMBER_OF_REQUESTS) == 0) {
- return "";
+ private void getRetryMetrics(StringBuilder metricBuilder) {
Review Comment:
javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
