anujmodi2021 commented on code in PR #7122: URL: https://github.com/apache/hadoop/pull/7122#discussion_r1855850024
########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/MetricsConstants.java: ########## @@ -0,0 +1,37 @@ +/** Review Comment: The constants here seems to be general, in future they can be used by other components as well. In fact we do use colon in tracing context class as well. Although there we have hardcoded string but it make sesnse to use same constant there as well. If we have some constants that can only be used by metrics code then it makes sense to group them. For example we have different files for constants related to http headers and query params. I feel these should go to internal constants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
